Conversation
previously the chosen metrics didn't make sense as a monitoring/performance data point, it was all just architectural relationships
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Cisco cNTP peer table collection so the emitted metric is a performance/monitoring datapoint (root delay) rather than primarily relationship/identity fields, and shifts identifying fields into metric tags.
Changes:
- Replaces
cntpPeersRefId/cntpPeersStratumas collected symbols withcntpPeersRootDelayas the primary metric. - Updates metric tags to include the peer’s address and stratum for dimensional breakdown.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
i3149
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously the chosen metrics didn't make sense as a monitoring/performance data point, it was all just architectural relationships. I've added the time delay as the metric and move the other values to metric tags